AaronFiore/electrum
1
0
Fork 0
Code Activity

swaps dialog: in callbacks, update either send or receive field, depending on which one follows

Browse Source 
before this, the content of the non-following field could be modified by callbacks
This commit is contained in:
ThomasV
2025-11-28 10:47:46 +01:00
parent 3f45c41981
commit 8bec3eafd2
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
electrum/gui/qt/swap_dialog.py
View File

@@ -150,13 +150,11 @@ class SwapDialog(WindowModalDialog, QtEventListener):
@qt_event_listener @qt_event_listener
def on_event_fee_histogram(self, *args): def on_event_fee_histogram(self, *args):
self.on_send_edited() self.update_send_receive()
self.on_recv_edited()
@qt_event_listener @qt_event_listener
def on_event_fee(self, *args): def on_event_fee(self, *args):
self.on_send_edited() self.update_send_receive()
self.on_recv_edited()
@qt_event_listener @qt_event_listener
def on_event_swap_offers_changed(self, recent_offers: Sequence['SwapOffer']): def on_event_swap_offers_changed(self, recent_offers: Sequence['SwapOffer']):
@@ -190,10 +188,7 @@ class SwapDialog(WindowModalDialog, QtEventListener):
self.config.FEE_POLICY = self.fee_policy.get_descriptor() self.config.FEE_POLICY = self.fee_policy.get_descriptor()
if not self.is_reverse: if not self.is_reverse:
self.fee_target_label.setText(self.fee_policy.get_target_text()) self.fee_target_label.setText(self.fee_policy.get_target_text())
if self.send_follows: self.update_send_receive()
self.on_recv_edited()
else:
self.on_send_edited()
self.update() self.update()
def _set_fee_slider_visibility(self, *, is_visible: bool): def _set_fee_slider_visibility(self, *, is_visible: bool):
@@ -277,6 +272,9 @@ class SwapDialog(WindowModalDialog, QtEventListener):
self.send_follows = True self.send_follows = True
self.needs_tx_update = True self.needs_tx_update = True
def update_send_receive(self):
self.on_recv_edited() if self.send_follows else self.on_send_edited()
def update(self): def update(self):
sm = self.swap_manager sm = self.swap_manager
w_base_unit = self.window.base_unit() w_base_unit = self.window.base_unit()
@@ -457,8 +455,7 @@ class SwapDialog(WindowModalDialog, QtEventListener):
def choose_swap_server(self, transport: 'SwapServerTransport') -> None: def choose_swap_server(self, transport: 'SwapServerTransport') -> None:
self.window.choose_swapserver_dialog(transport) # type: ignore self.window.choose_swapserver_dialog(transport) # type: ignore
self.update() self.update()
self.on_send_edited() self.update_send_receive()
self.on_recv_edited()
class SwapServerDialog(WindowModalDialog, QtEventListener): class SwapServerDialog(WindowModalDialog, QtEventListener):