AaronFiore/electrum
1
0
Fork 0
Code Activity

wallet: add get_label_for_address, and make get_label private

Browse Source 
fixes https://github.com/spesmilo/electrum/issues/7919

In the past, when creating payment requests, we keyed them by on-chain address,
and set/saved the msg of the request as label for the address.
Many places in the code were calling wallet.get_label(addr) with the expectation that
relevant payment requests are found and their message/description (if any) is considered.

wallet.get_label(key) is now made private, and instead the explicit non-polymorphic
wallet.get_label_for_{address,rhash,txid} alternatives should be used.
This commit is contained in:
SomberNight
2022-08-09 17:13:44 +02:00
parent 9279463fae
commit 7b095158bf
13 changed files with 35 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
electrum/plugins/labels/labels.py
View File

@@ -154,7 +154,7 @@ class LabelsPlugin(BasePlugin):
result[key] = value
for key, value in result.items():
if force or not wallet.get_label(key):
if force or not wallet._get_label(key):
wallet._set_label(key, value)
self.logger.info(f"received {len(response)} labels")