network: disconnect from server on malformed header subs

closes #4478
2018-07-03 17:17:20 +02:00
parent 8b1051fa24
commit 75a85a8161
1 changed files with 6 additions and 1 deletions
--- a/lib/network.py
+++ b/lib/network.py
@@ -1065,7 +1065,12 @@ class Network(util.DaemonThread):
        self.on_stop()

    def on_notify_header(self, interface, header_dict):
-        header_hex, height = header_dict['hex'], header_dict['height']
+        try:
+            header_hex, height = header_dict['hex'], header_dict['height']
+        except KeyError:
+            # no point in keeping this connection without headers sub
+            self.connection_down(interface.server)
+            return
        header = blockchain.deserialize_header(util.bfh(header_hex), height)
        if height < self.max_checkpoint():
            self.connection_down(interface.server)