AaronFiore/electrum
1
0
Fork 0
Code Activity

qml: QEAmount returns 0 when amount is undefined

Browse Source 
an undefined amount triggers a hard to debug crash when None/undefined is passing the
python/QObject boundary, so let's default to 0
This commit is contained in:
Sander van Grieken
2022-08-12 14:56:00 +02:00
parent 13570a465c
commit 74e9c848cc
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
electrum/gui/qml/qetypes.py
View File

@@ -31,10 +31,16 @@ class QEAmount(QObject):
@pyqtProperty('qint64', notify=valueChanged) @pyqtProperty('qint64', notify=valueChanged)
def satsInt(self): def satsInt(self):
if self._amount_sat is None: # should normally be defined when accessing this property
self._logger.warning('amount_sat is undefined, returning 0')
return 0
return self._amount_sat return self._amount_sat
@pyqtProperty('qint64', notify=valueChanged) @pyqtProperty('qint64', notify=valueChanged)
def msatsInt(self): def msatsInt(self):
if self._amount_msat is None: # should normally be defined when accessing this property
self._logger.warning('amount_msat is undefined, returning 0')
return 0
return self._amount_msat return self._amount_msat
@pyqtProperty(str, notify=valueChanged) @pyqtProperty(str, notify=valueChanged)