AaronFiore/electrum
1
0
Fork 0
Code Activity

Populate tx_status_cache before it's used, not after

Browse Source 
The endInsertRows() call triggers the main calls to get_data_for_role():
in the current order, the try/except goes to the exception every time

In the updated order, it doesn't do it ever

We have full control over what's in the cache,
and we always fully populate it, so we can get rid of the fallback
This commit is contained in:
наб
2025-06-16 16:30:42 +02:00
parent e28836eb1d
commit 60cb94f845
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
electrum/gui/qt/history_list.py
View File

@@ -317,6 +317,13 @@ class HistoryModel(CustomModel, Logger):
balance += node._data['value'].value balance += node._data['value'].value
node._data['balance'] = Satoshis(balance) node._data['balance'] = Satoshis(balance)
# update tx_status_cache
self.tx_status_cache.clear()
for txid, tx_item in transactions.items():
if not tx_item.get('lightning', False):
tx_mined_info = self._tx_mined_info_from_tx_item(tx_item)
self.tx_status_cache[txid] = self.window.wallet.get_tx_status(txid, tx_mined_info)
new_length = self._root.childCount() new_length = self._root.childCount()
self.beginInsertRows(QModelIndex(), 0, new_length-1) self.beginInsertRows(QModelIndex(), 0, new_length-1)
self.transactions = transactions self.transactions = transactions
@@ -336,12 +343,6 @@ class HistoryModel(CustomModel, Logger):
end_date = self.transactions.value_from_pos(len(self.transactions) - 1).get('date') or end_date end_date = self.transactions.value_from_pos(len(self.transactions) - 1).get('date') or end_date
self.view.years = [str(i) for i in range(start_date.year, end_date.year + 1)] self.view.years = [str(i) for i in range(start_date.year, end_date.year + 1)]
self.view.period_combo.insertItems(1, self.view.years) self.view.period_combo.insertItems(1, self.view.years)
# update tx_status_cache
self.tx_status_cache.clear()
for txid, tx_item in self.transactions.items():
if not tx_item.get('lightning', False):
tx_mined_info = self._tx_mined_info_from_tx_item(tx_item)
self.tx_status_cache[txid] = self.window.wallet.get_tx_status(txid, tx_mined_info)
# update counter # update counter
num_tx = len(self.transactions) num_tx = len(self.transactions)
if self.view: if self.view: