From 53b3c1de3e52a7687efd770570684924e21c79f7 Mon Sep 17 00:00:00 2001 From: Oren Date: Sat, 24 May 2025 04:01:41 +0300 Subject: [PATCH] control prompt_if_unsaved In the current logic, even if prompt_if_unsaved was False, the prompt will appear if the signing is complete (and unsaved). --- electrum/gui/qt/transaction_dialog.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py index 0ebaf8c98..c0a4f7435 100644 --- a/electrum/gui/qt/transaction_dialog.py +++ b/electrum/gui/qt/transaction_dialog.py @@ -461,6 +461,7 @@ class TxDialog(QDialog, MessageBoxMixin): *, parent: 'ElectrumWindow', prompt_if_unsaved: bool, + prompt_if_complete_unsaved: bool = True, external_keypairs: Mapping[bytes, bytes] = None, invoice: 'Invoice' = None, on_closed: Callable[[Optional[Transaction]], None] = None, @@ -477,6 +478,7 @@ class TxDialog(QDialog, MessageBoxMixin): self.wallet = parent.wallet self.invoice = invoice self.prompt_if_unsaved = prompt_if_unsaved + self.prompt_if_complete_unsaved = prompt_if_complete_unsaved self.on_closed = on_closed self.saved = False self.desc = None @@ -711,7 +713,7 @@ class TxDialog(QDialog, MessageBoxMixin): def sign(self): def sign_done(success): - if self.tx.is_complete(): + if self.tx.is_complete() and self.prompt_if_complete_unsaved: self.prompt_if_unsaved = True self.saved = False self.update()