AaronFiore/electrum
1
0
Fork 0
Code Activity

ExchangeRate: return NaN if rate is 0

Browse Source 
Prevent DivisionByZero exceptions by returning `Decimal('NaN')
instead of `Decimal(0)` if the exchange rate is 0.

Fixes https://github.com/spesmilo/electrum/issues/10403

```
>>> bool(Decimal(0))
False
```
This commit is contained in:
f321x
2026-01-13 13:57:14 +01:00
parent 5778fa401d
commit 5199c6c742
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
electrum/exchange_rate.py
View File

@@ -209,7 +209,7 @@ class ExchangeBase(Logger):
if ccy == 'BTC': if ccy == 'BTC':
return Decimal(1) return Decimal(1)
rate = self._quotes.get(ccy) rate = self._quotes.get(ccy)
if rate is None: if not rate: # don't return 0 to prevent DivisionByZero exceptions
return Decimal('NaN') return Decimal('NaN')
if self._quotes_timestamp + SPOT_RATE_EXPIRY < time.time(): if self._quotes_timestamp + SPOT_RATE_EXPIRY < time.time():
# Our rate is stale. Probably better to return no rate than an incorrect one. # Our rate is stale. Probably better to return no rate than an incorrect one.