do not base64encode signatures in requests
This commit is contained in:
@@ -5,7 +5,6 @@ from binascii import hexlify
|
||||
from struct import pack,unpack
|
||||
from sys import stderr
|
||||
from time import sleep
|
||||
from base64 import b64encode, b64decode
|
||||
|
||||
import electrum
|
||||
from electrum_gui.qt.password_dialog import make_password_dialog, run_password_dialog
|
||||
@@ -345,8 +344,7 @@ class BTChipWallet(BIP32_HD_Wallet):
|
||||
s = str(s)
|
||||
|
||||
# And convert it
|
||||
|
||||
return b64encode(chr(27 + 4 + (signature[0] & 0x01)) + r + s)
|
||||
return chr(27 + 4 + (signature[0] & 0x01)) + r + s
|
||||
|
||||
def sign_transaction(self, tx, password):
|
||||
if tx.is_complete():
|
||||
|
||||
@@ -80,6 +80,7 @@ class Plugin(BasePlugin):
|
||||
addr = self.get_my_addr(tx)
|
||||
message = "Please verify if %s is GreenAddress instant confirmed" % tx.hash()
|
||||
sig = self.wallet.sign_message(addr, message, password)
|
||||
sig = base64.b64encode(sig)
|
||||
|
||||
# 2. send the request
|
||||
response = requests.request("GET", ("https://greenaddress.it/verify/?signature=%s&txhash=%s" % (urllib.quote(sig), tx.hash())),
|
||||
|
||||
@@ -2,7 +2,6 @@ from binascii import unhexlify
|
||||
from struct import pack
|
||||
from sys import stderr
|
||||
from time import sleep
|
||||
from base64 import b64encode, b64decode
|
||||
import unicodedata
|
||||
import threading
|
||||
import re
|
||||
@@ -459,8 +458,7 @@ class TrezorWallet(BIP32_HD_Wallet):
|
||||
give_error(e)
|
||||
finally:
|
||||
self.plugin.handler.stop()
|
||||
b64_msg_sig = b64encode(msg_sig.signature)
|
||||
return str(b64_msg_sig)
|
||||
return msg_sig.signature
|
||||
|
||||
def sign_transaction(self, tx, password):
|
||||
if tx.is_complete():
|
||||
|
||||
Reference in New Issue
Block a user