AaronFiore/electrum
1
0
Fork 0
Code Activity

transaction: never put ypub/zpub in psbts, only plain xpubs

Browse Source 
BIP-0174 specifies using standard bip32-compliant serialization for extended keys.
> The 78 byte serialized extended public key as defined by BIP 32.

closes https://github.com/spesmilo/electrum/issues/8036
This commit is contained in:
SomberNight
2022-10-27 16:03:05 +00:00
parent 45a939c146
commit 30ac889656
2 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
electrum/keystore.py
View File

@@ -523,9 +523,13 @@ class Xpub(MasterPublicKeyMixin):
child_number_int = der_full[-1] if len(der_full) >= 1 else 0
child_number_bytes = child_number_int.to_bytes(length=4, byteorder="big")
fingerprint = bytes(4) if depth == 0 else bip32node.fingerprint
bip32node = bip32node._replace(depth=depth,
fingerprint=fingerprint,
child_number=child_number_bytes)
bip32node = bip32node._replace(
depth=depth,
fingerprint=fingerprint,
child_number=child_number_bytes,
# only put plain xpubs (not ypub/zpub) in PSBTs:
xtype="standard",
)
return bip32node.to_xpub()
def add_key_origin_from_root_node(self, *, derivation_prefix: str, root_node: BIP32Node):