AaronFiore/electrum
1
0
Fork 0
Code Activity

lnworker: prevent creation of PaymentInfo with 0 exp

Browse Source 
In some parts of the application 0 (sec) == no expiry, however we
use `LN_EXPIRY_NEVER` (100 years) instead of 0 for lightning invoices.

This replaces a 0 second expiry with `LN_EXPIRY_NEVER` in
`LNWallet.create_payment_info()` to prevent htlcs for no-expiry invoices
from getting failed incorrectly (which the assert prevented)
and fix the assertion error in #10350.

Fixes #10350.

# Conflicts:
#	electrum/lnworker.py
This commit is contained in:
f321x
2025-12-10 11:44:45 +01:00
parent 0b886cf7a8
commit 2f2340d69f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
electrum/lnworker.py
View File

@@ -146,7 +146,7 @@ class PaymentInfo:
assert isinstance(self.direction, int) assert isinstance(self.direction, int)
assert isinstance(self.status, int) assert isinstance(self.status, int)
assert isinstance(self.min_final_cltv_delta, int) assert isinstance(self.min_final_cltv_delta, int)
assert isinstance(self.expiry_delay, int) and self.expiry_delay > 0 assert isinstance(self.expiry_delay, int) and self.expiry_delay > 0, repr(self.expiry_delay)
assert isinstance(self.creation_ts, int) assert isinstance(self.creation_ts, int)
assert isinstance(self.invoice_features, LnFeatures) assert isinstance(self.invoice_features, LnFeatures)
@@ -2414,7 +2414,7 @@ class LNWallet(LNWorker):
direction=RECEIVED, direction=RECEIVED,
status=PR_UNPAID, status=PR_UNPAID,
min_final_cltv_delta=min_final_cltv_delta, min_final_cltv_delta=min_final_cltv_delta,
expiry_delay=exp_delay, expiry_delay=exp_delay or LN_EXPIRY_NEVER,
invoice_features=invoice_features, invoice_features=invoice_features,
) )
self.save_preimage(payment_hash, payment_preimage, write_to_disk=False) self.save_preimage(payment_hash, payment_preimage, write_to_disk=False)