AaronFiore/electrum
1
0
Fork 0
Code Activity

qml: fix doNotify for Windows. lol

Browse Source 
```
319.55 | E | gui.qml.qeapp.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
  File "...\electrum\electrum\util.py", line 1130, in run_with_except_hook
    run_original(*args2, **kwargs2)
  File "...\Python310\lib\threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "...\plyer\platforms\win\libs\balloontip.py", line 206, in balloon_tip
    WindowsBalloonTip(**kwargs)
  File "...\plyer\platforms\win\libs\balloontip.py", line 130, in __init__
    raise Exception('Could not load icon {}'.format(app_icon))
Exception: Could not load icon ...\electrum\electrum\gui\icons\electrum.png
```
This commit is contained in:
SomberNight
2025-07-18 01:37:07 +00:00
parent e658fa4e04
commit 23adf13070
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
electrum/gui/qml/qeapp.py
View File

@@ -161,14 +161,17 @@ class QEAppController(BaseCrashReporter, QObject):
def doNotify(self, wallet_name, message): def doNotify(self, wallet_name, message):
self.logger.debug(f'sending push notification to OS: {message=!r}') self.logger.debug(f'sending push notification to OS: {message=!r}')
if os.name == 'nt':
icon = "" # plyer wants image to be in .ico format on Windows
else:
icon = os.path.join(
os.path.dirname(os.path.dirname(os.path.realpath(__file__))), "icons", "electrum.png",
)
try: try:
# TODO: lazy load not in UI thread please # TODO: lazy load not in UI thread please
global notification global notification
if not notification: if not notification:
from plyer import notification from plyer import notification
icon = os.path.join(
os.path.dirname(os.path.dirname(os.path.realpath(__file__))), "icons", "electrum.png",
)
notification.notify('Electrum', message, app_icon=icon, app_name='Electrum') notification.notify('Electrum', message, app_icon=icon, app_name='Electrum')
except ImportError: except ImportError:
self.logger.warning('Notification: needs plyer; `python3 -m pip install plyer`') self.logger.warning('Notification: needs plyer; `python3 -m pip install plyer`')