AaronFiore/electrum
1
0
Fork 0
Code Activity

i18n: don't translate empty string

Browse Source 
see #7158

```
$ ./contrib/pull_locale
Found 260 files to translate
Generate template
electrum/gui/qt/installwizard.py:265: warning: Empty msgid.  It is reserved by GNU gettext:
                                               gettext("") returns the header entry with
                                               meta information, not the empty string.
electrum/gui/qt/channels_list.py:49: warning: Empty msgid.  It is reserved by GNU gettext:
                                              gettext("") returns the header entry with
                                              meta information, not the empty string.
```
This commit is contained in:
SomberNight
2021-04-01 03:33:16 +02:00
parent f87727c195
commit 210ff647fa
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
electrum/gui/qt/channels_list.py
View File

@@ -46,7 +46,7 @@ class ChannelsList(MyTreeView):
headers = { headers = {
Columns.SHORT_CHANID: _('Short Channel ID'), Columns.SHORT_CHANID: _('Short Channel ID'),
Columns.NODE_ALIAS: _('Node alias'), Columns.NODE_ALIAS: _('Node alias'),
Columns.FEATURES: _(''), Columns.FEATURES: "",
Columns.CAPACITY: _('Capacity'), Columns.CAPACITY: _('Capacity'),
Columns.LOCAL_BALANCE: _('Can send'), Columns.LOCAL_BALANCE: _('Can send'),
Columns.REMOTE_BALANCE: _('Can receive'), Columns.REMOTE_BALANCE: _('Can receive'),

2
electrum/gui/qt/installwizard.py
View File

@@ -262,7 +262,7 @@ class InstallWizard(QDialog, MessageBoxMixin, BaseWizard):
self.logger.exception('') self.logger.exception('')
msg = _('Cannot read file') + f'\n{repr(e)}' msg = _('Cannot read file') + f'\n{repr(e)}'
else: else:
msg = _('') msg = ""
self.next_button.setEnabled(temp_storage is not None) self.next_button.setEnabled(temp_storage is not None)
user_needs_to_enter_password = False user_needs_to_enter_password = False
if temp_storage: if temp_storage:

4
electrum/i18n.py
View File

@@ -33,7 +33,9 @@ language = gettext.translation('electrum', LOCALE_DIR, fallback=True)
# note: f-strings cannot be translated! see https://stackoverflow.com/q/49797658 # note: f-strings cannot be translated! see https://stackoverflow.com/q/49797658
# So this does not work: _(f"My name: {name}") # So this does not work: _(f"My name: {name}")
# instead use .format: _("My name: {}").format(name) # instead use .format: _("My name: {}").format(name)
def _(x): def _(x: str) -> str:
if x == "":
return "" # empty string must not be translated. see #7158
global language global language
return language.gettext(x) return language.gettext(x)