AaronFiore/electrum
1
0
Fork 0
Code Activity

build: don't allow setuptools to sneakily install build-time deps

Browse Source 
see https://pip.pypa.io/en/stable/reference/pip_install/#controlling-setup-requires
> Setuptools offers the setup_requires setup() keyword for specifying
> dependencies that need to be present in order for the setup.py
> script to run. Internally, Setuptools uses easy_install to
> fulfill these dependencies.
> pip has no way to control how these dependencies are located.
> None of the package index options have an effect.

With these changes, we will now instead hard fail if this were to happen.

related: https://github.com/spesmilo/electrum/issues/5859#issuecomment-743621898
This commit is contained in:
SomberNight
2020-12-12 02:52:38 +01:00
parent a83805e00b
commit 19f806ddf4
6 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/osx/make_osx
View File

@@ -72,6 +72,8 @@ PYTHON_CONFIGURE_OPTS="--enable-framework" pyenv install -s $PYTHON_VERSION && \
pyenv global $PYTHON_VERSION || \
fail "Unable to use Python $PYTHON_VERSION"
break_legacy_easy_install
# create a fresh virtualenv
# This helps to avoid older versions of pip-installed dependencies interfering with the build.
VENV_DIR="$CONTRIB_OSX/build-venv"