AaronFiore/electrum
1
0
Fork 0
Code Activity

network triggers: 'verified' notification now includes wallet

Browse Source 
this is a performance optimisation.

measurements using a large wallet with 11k txns:
syncing XPUB for the first time takes 10 seconds. leaving window open, and
syncing same XPUB again in new window takes 30 seconds. in third window,
it takes ~50 seconds. then ~70s. presumably scaling linearly.
this is due to the history_list.update_item call being CPU-heavy.
now all of them take 10 seconds.
This commit is contained in:
SomberNight
2018-09-18 01:40:34 +02:00
parent 24ec7ce6b8
commit 11bf084a1f
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
electrum/address_synchronizer.py
View File

@@ -593,7 +593,7 @@ class AddressSynchronizer(PrintError):
self.unverified_tx.pop(tx_hash, None) self.unverified_tx.pop(tx_hash, None)
self.verified_tx[tx_hash] = info self.verified_tx[tx_hash] = info
tx_mined_status = self.get_tx_height(tx_hash) tx_mined_status = self.get_tx_height(tx_hash)
self.network.trigger_callback('verified', tx_hash, tx_mined_status) self.network.trigger_callback('verified', self, tx_hash, tx_mined_status)
def get_unverified_txs(self): def get_unverified_txs(self):
'''Returns a map from tx hash to transaction height''' '''Returns a map from tx hash to transaction height'''

4
electrum/gui/qt/main_window.py
View File

@@ -316,7 +316,9 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError):
elif event == 'banner': elif event == 'banner':
self.console.showMessage(args[0]) self.console.showMessage(args[0])
elif event == 'verified': elif event == 'verified':
self.history_list.update_item(*args) wallet, tx_hash, tx_mined_status = args
if wallet == self.wallet:
self.history_list.update_item(tx_hash, tx_mined_status)
elif event == 'fee': elif event == 'fee':
if self.config.is_dynfee(): if self.config.is_dynfee():
self.fee_slider.update() self.fee_slider.update()