AaronFiore/electrum
1
0
Fork 0
Code Activity

qt history: data() should return QVariant

Browse Source 
the docs says so,
and also HistoryList.create_menu() was crashing sometimes re "Copy {}"
This commit is contained in:
SomberNight
2018-12-10 19:42:31 +01:00
parent 4e7b2f3ea3
commit 0ec7005f90
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
electrum/gui/qt/history_list.py
View File

@@ -105,7 +105,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
def index(self, row: int, column: int, parent: QModelIndex): def index(self, row: int, column: int, parent: QModelIndex):
return self.createIndex(row, column) return self.createIndex(row, column)
def data(self, index: QModelIndex, role: Qt.ItemDataRole): def data(self, index: QModelIndex, role: Qt.ItemDataRole) -> QVariant:
# note: this method is performance-critical. # note: this method is performance-critical.
# it is called a lot, and so must run extremely fast. # it is called a lot, and so must run extremely fast.
assert index.isValid() assert index.isValid()
@@ -161,7 +161,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
and not tx_item.get('fiat_default') and tx_item.get('fiat_value') is not None: and not tx_item.get('fiat_default') and tx_item.get('fiat_value') is not None:
blue_brush = QBrush(QColor("#1E1EFF")) blue_brush = QBrush(QColor("#1E1EFF"))
return QVariant(blue_brush) return QVariant(blue_brush)
return None return QVariant()
if col == HistoryColumns.STATUS_TEXT: if col == HistoryColumns.STATUS_TEXT:
return QVariant(status_str) return QVariant(status_str)
elif col == HistoryColumns.DESCRIPTION: elif col == HistoryColumns.DESCRIPTION:
@@ -187,7 +187,7 @@ class HistoryModel(QAbstractItemModel, PrintError):
return QVariant(self.parent.fx.format_fiat(cg)) return QVariant(self.parent.fx.format_fiat(cg))
elif col == HistoryColumns.TXID: elif col == HistoryColumns.TXID:
return QVariant(tx_hash) return QVariant(tx_hash)
return None return QVariant()
def parent(self, index: QModelIndex): def parent(self, index: QModelIndex):
return QModelIndex() return QModelIndex()