AaronFiore/electrum
1
0
Fork 0
Code Activity

TxDialog: fix hooks. only show psbt widgets when applicable.

Browse Source 
users of 'transaction_dialog' were assuming that dialog.tx is already set
This commit is contained in:
SomberNight
2019-11-12 23:02:02 +01:00
parent 05c496edd1
commit 0c0a6b2145
4 changed files with 29 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
electrum/plugins/cosigner_pool/qt.py
View File

@@ -149,25 +149,26 @@ class Plugin(BasePlugin):
d.cosigner_send_button = b = QPushButton(_("Send to cosigner"))
b.clicked.connect(lambda: self.do_send(d.tx))
d.buttons.insert(0, b)
self.transaction_dialog_update(d)
b.setVisible(False)
@hook
def transaction_dialog_update(self, d: 'TxDialog'):
if d.tx.is_complete() or d.wallet.can_sign(d.tx):
d.cosigner_send_button.hide()
d.cosigner_send_button.setVisible(False)
return
for window, xpub, K, _hash in self.cosigner_list:
if window.wallet == d.wallet and self.cosigner_can_sign(d.tx, xpub):
d.cosigner_send_button.show()
d.cosigner_send_button.setVisible(True)
break
else:
d.cosigner_send_button.hide()
d.cosigner_send_button.setVisible(False)
def cosigner_can_sign(self, tx: Transaction, cosigner_xpub: str) -> bool:
if not isinstance(tx, PartialTransaction):
return False
if tx.is_complete():
return False
# TODO this is broken currently as it assumes tx.xpubs
return cosigner_xpub in {bip32node.to_xpub() for bip32node in tx.xpubs}
def do_send(self, tx: Union[Transaction, PartialTransaction]):