AaronFiore/electrum
1
0
Fork 0
Code Activity

stricter tx deserialization: forbid output amount values over 21 million btc

Browse Source
This commit is contained in:
SomberNight
2018-06-12 14:33:22 +02:00
parent 5eb1cbef92
commit 0b78cb5e6b
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/bitcoin.py
View File

@@ -38,6 +38,7 @@ from .crypto import Hash, sha256, hash_160
COINBASE_MATURITY = 100 COINBASE_MATURITY = 100
COIN = 100000000 COIN = 100000000
TOTAL_COIN_SUPPLY_LIMIT_IN_BTC = 21000000
# supported types of transaction outputs # supported types of transaction outputs
TYPE_ADDRESS = 0 TYPE_ADDRESS = 0

2
lib/transaction.py
View File

@@ -534,6 +534,8 @@ def parse_witness(vds, txin, full_parse: bool):
def parse_output(vds, i): def parse_output(vds, i):
d = {} d = {}
d['value'] = vds.read_int64() d['value'] = vds.read_int64()
if d['value'] > TOTAL_COIN_SUPPLY_LIMIT_IN_BTC * COIN:
raise SerializationError('invalid output amount (too large)')
scriptPubKey = vds.read_bytes(vds.read_compact_size()) scriptPubKey = vds.read_bytes(vds.read_compact_size())
d['type'], d['address'] = get_address_from_output_script(scriptPubKey) d['type'], d['address'] = get_address_from_output_script(scriptPubKey)
d['scriptPubKey'] = bh2u(scriptPubKey) d['scriptPubKey'] = bh2u(scriptPubKey)