AaronFiore/electrum
1
0
Fork 0
Code Activity

qt tx dialog: show_qr to warn if QR code is missing data

Browse Source 
When exporting a tx as qr code, the prev txs are omitted to save space.
This causes problems with offline signers: software electrum signers will
just warn and then proceed, but hw devices will typically error.
This commit is contained in:
SomberNight
2023-03-30 14:32:31 +00:00
parent 4647fda04f
commit 0a3e286f1d
6 changed files with 25 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
electrum/gui/qt/transaction_dialog.py
View File

@@ -595,9 +595,15 @@ class TxDialog(QDialog, MessageBoxMixin):
def show_qr(self, *, tx: Transaction = None):
if tx is None:
tx = self.tx
qr_data = tx.to_qr_data()
qr_data, is_complete = tx.to_qr_data()
help_text = None
if not is_complete:
help_text = _(
"""Warning: Some data (prev txs / "full utxos") was left """
"""out of the QR code as it would not fit. This might cause issues if signing offline. """
"""As a workaround, try exporting the tx as file or text instead.""")
try:
self.main_window.show_qrcode(qr_data, 'Transaction', parent=self)
self.main_window.show_qrcode(qr_data, 'Transaction', parent=self, help_text=help_text)
except qrcode.exceptions.DataOverflowError:
self.show_error(_('Failed to display QR code.') + '\n' +
_('Transaction is too large in size.'))