no more "import *"

fixes #5101
fixes #5105

electrum/plugins/audio_modem/qt.py

@@ -5,15 +5,13 @@ from io import BytesIO
 import sys
 import platform
 
+from PyQt5.QtWidgets import (QComboBox, QGridLayout, QLabel, QPushButton)
+
 from electrum.plugin import BasePlugin, hook
 from electrum.gui.qt.util import WaitingDialog, EnterButton, WindowModalDialog, read_QIcon
 from electrum.util import print_msg, print_error
 from electrum.i18n import _
 
-from PyQt5.QtGui import *
-from PyQt5.QtCore import *
-from PyQt5.QtWidgets import (QComboBox, QGridLayout, QLabel, QPushButton)
-
 try:
     import amodem.audio
     import amodem.main

electrum/plugins/coldcard/qt.py

@@ -1,9 +1,13 @@
 import time
+from functools import partial
+
+from PyQt5.QtCore import Qt, pyqtSignal
+from PyQt5.QtWidgets import QPushButton, QLabel, QVBoxLayout, QWidget, QGridLayout
 
 from electrum.i18n import _
 from electrum.plugin import hook
 from electrum.wallet import Standard_Wallet
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import WindowModalDialog, CloseButton, get_parent_main_window
 
 from .coldcard import ColdcardPlugin
 from ..hw_wallet.qt import QtHandlerBase, QtPluginBase

electrum/plugins/cosigner_pool/qt.py

@@ -26,8 +26,7 @@
 import time
 from xmlrpc.client import ServerProxy
 
-from PyQt5.QtGui import *
-from PyQt5.QtCore import *
+from PyQt5.QtCore import QObject, pyqtSignal
 from PyQt5.QtWidgets import QPushButton
 
 from electrum import util, keystore, ecc, bip32, crypto

electrum/plugins/email_requests/qt.py

@@ -37,8 +37,7 @@ from email.mime.multipart import MIMEMultipart
 from email.mime.base import MIMEBase
 from email.encoders import encode_base64
 
-from PyQt5.QtGui import *
-from PyQt5.QtCore import *
+from PyQt5.QtCore import QObject, pyqtSignal, QThread
 from PyQt5.QtWidgets import (QVBoxLayout, QLabel, QGridLayout, QLineEdit,
                              QInputDialog)
 

electrum/plugins/hw_wallet/qt.py

@@ -25,11 +25,14 @@
 # SOFTWARE.
 
 import threading
+from functools import partial
 
-from PyQt5.QtWidgets import QVBoxLayout, QLabel
+from PyQt5.QtCore import QObject, pyqtSignal
+from PyQt5.QtWidgets import QVBoxLayout, QLineEdit, QHBoxLayout, QLabel
 
 from electrum.gui.qt.password_dialog import PasswordLayout, PW_PASSPHRASE
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import (read_QIcon, WWLabel, OkButton, WindowModalDialog,
+                                  Buttons, CancelButton, TaskThread)
 
 from electrum.i18n import _
 from electrum.util import PrintError

electrum/plugins/keepkey/qt.py

@@ -1,11 +1,15 @@
 from functools import partial
 import threading
 
-from PyQt5.QtCore import Qt
-from PyQt5.QtWidgets import QGridLayout, QInputDialog, QPushButton
-from PyQt5.QtWidgets import QVBoxLayout, QLabel
+from PyQt5.QtCore import Qt, QEventLoop, pyqtSignal, QRegExp
+from PyQt5.QtGui import QRegExpValidator
+from PyQt5.QtWidgets import (QVBoxLayout, QLabel, QGridLayout, QPushButton,
+                             QHBoxLayout, QButtonGroup, QGroupBox, QDialog,
+                             QTextEdit, QLineEdit, QRadioButton, QCheckBox, QWidget,
+                             QMessageBox, QFileDialog, QSlider, QTabWidget)
 
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import (WindowModalDialog, WWLabel, Buttons, CancelButton,
+                                  OkButton, CloseButton)
 from electrum.i18n import _
 from electrum.plugin import hook
 from electrum.util import bh2u

electrum/plugins/labels/qt.py

@@ -2,15 +2,12 @@ from functools import partial
 import traceback
 import sys
 
-from PyQt5.QtGui import *
-from PyQt5.QtCore import *
+from PyQt5.QtCore import QObject, pyqtSignal
 from PyQt5.QtWidgets import (QHBoxLayout, QLabel, QVBoxLayout)
 
 from electrum.plugin import hook
 from electrum.i18n import _
-from electrum.gui.qt import EnterButton
-from electrum.gui.qt.util import ThreadedButton, Buttons
-from electrum.gui.qt.util import WindowModalDialog, OkButton
+from electrum.gui.qt.util import ThreadedButton, Buttons, EnterButton, WindowModalDialog, OkButton
 
 from .labels import LabelsPlugin
 

electrum/plugins/ledger/auth2fa.py

@@ -7,17 +7,16 @@ from binascii import hexlify, unhexlify
 
 import websocket
 
-from PyQt5.QtWidgets import QDialog, QLineEdit, QTextEdit, QVBoxLayout, QLabel
-import PyQt5.QtCore as QtCore
-from PyQt5.QtWidgets import *
+from PyQt5.QtWidgets import (QDialog, QLineEdit, QTextEdit, QVBoxLayout, QLabel,
+                             QWidget, QHBoxLayout, QComboBox, QPushButton)
+from PyQt5.QtCore import QThread, pyqtSignal
 
-from btchip.btchip import *
+from btchip.btchip import BTChipException
 
 from electrum.i18n import _
 from electrum.util import print_msg
 from electrum import constants, bitcoin
 from electrum.gui.qt.qrcodewidget import QRCodeWidget
-from electrum.gui.qt.util import *
 
 
 DEBUG = False

electrum/plugins/ledger/qt.py

@@ -1,9 +1,14 @@
+from functools import partial
+
 #from btchip.btchipPersoWizard import StartBTChipPersoDialog
 
+from PyQt5.QtCore import pyqtSignal
+from PyQt5.QtWidgets import QInputDialog, QLabel, QVBoxLayout, QLineEdit
+
 from electrum.i18n import _
 from electrum.plugin import hook
 from electrum.wallet import Standard_Wallet
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import WindowModalDialog
 
 from .ledger import LedgerPlugin
 from ..hw_wallet.qt import QtHandlerBase, QtPluginBase

electrum/plugins/revealer/qt.py

@@ -11,20 +11,28 @@ Tiago Romagnani Silveira, 2017
 
 import os
 import random
-import qrcode
 import traceback
 from decimal import Decimal
+from functools import partial
+import sys
 
+import qrcode
 from PyQt5.QtPrintSupport import QPrinter
+from PyQt5.QtCore import Qt, QRectF, QRect, QSizeF, QUrl, QPoint, QSize
+from PyQt5.QtGui import (QPixmap, QImage, QBitmap, QPainter, QFontDatabase, QPen, QFont,
+                         QColor, QDesktopServices, qRgba, QPainterPath)
+from PyQt5.QtWidgets import (QGridLayout, QVBoxLayout, QHBoxLayout, QLabel,
+                             QPushButton, QLineEdit)
 
 from electrum.plugin import hook
 from electrum.i18n import _
-from electrum.util import make_dir, InvalidPassword, UserCancelled, bh2u, bfh
-from electrum.gui.qt.util import *
+from electrum.util import make_dir, InvalidPassword, UserCancelled
+from electrum.gui.qt.util import (read_QIcon, EnterButton, WWLabel, icon_path,
+                                  WindowModalDialog, Buttons, CloseButton, OkButton)
 from electrum.gui.qt.qrtextedit import ScanQRTextEdit
 from electrum.gui.qt.main_window import StatusBarButton
 
-from .revealer import RevealerPlugin, VersionedSeed
+from .revealer import RevealerPlugin
 
 
 class Plugin(RevealerPlugin):

electrum/plugins/safe_t/qt.py

@@ -1,11 +1,15 @@
 from functools import partial
 import threading
 
-from PyQt5.QtCore import Qt
-from PyQt5.QtWidgets import QGridLayout, QInputDialog, QPushButton
-from PyQt5.QtWidgets import QVBoxLayout, QLabel
+from PyQt5.QtCore import Qt, pyqtSignal, QRegExp
+from PyQt5.QtGui import QRegExpValidator
+from PyQt5.QtWidgets import (QVBoxLayout, QLabel, QGridLayout, QPushButton,
+                             QHBoxLayout, QButtonGroup, QGroupBox,
+                             QTextEdit, QLineEdit, QRadioButton, QCheckBox, QWidget,
+                             QMessageBox, QFileDialog, QSlider, QTabWidget)
 
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import (WindowModalDialog, WWLabel, Buttons, CancelButton,
+                                  OkButton, CloseButton)
 from electrum.i18n import _
 from electrum.plugin import hook
 from electrum.util import bh2u

electrum/plugins/trezor/qt.py

@@ -1,11 +1,14 @@
 from functools import partial
 import threading
 
-from PyQt5.QtCore import Qt
-from PyQt5.QtWidgets import QGridLayout, QInputDialog, QPushButton
-from PyQt5.QtWidgets import QVBoxLayout, QLabel
+from PyQt5.QtCore import Qt, QEventLoop, pyqtSignal
+from PyQt5.QtWidgets import (QVBoxLayout, QLabel, QGridLayout, QPushButton,
+                             QHBoxLayout, QButtonGroup, QGroupBox, QDialog,
+                             QLineEdit, QRadioButton, QCheckBox, QWidget,
+                             QMessageBox, QFileDialog, QSlider, QTabWidget)
 
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import (WindowModalDialog, WWLabel, Buttons, CancelButton,
+                                  OkButton, CloseButton)
 from electrum.i18n import _
 from electrum.plugin import hook
 from electrum.util import bh2u

electrum/plugins/trustedcoin/qt.py

@@ -25,14 +25,16 @@
 
 from functools import partial
 import threading
-from threading import Thread
-import re
-from decimal import Decimal
+import sys
+import os
 
-from PyQt5.QtGui import *
-from PyQt5.QtCore import *
+from PyQt5.QtGui import QPixmap
+from PyQt5.QtCore import QObject, pyqtSignal
+from PyQt5.QtWidgets import (QTextEdit, QVBoxLayout, QLabel, QGridLayout, QHBoxLayout,
+                             QRadioButton, QCheckBox, QLineEdit)
 
-from electrum.gui.qt.util import *
+from electrum.gui.qt.util import (read_QIcon, WindowModalDialog, WaitingDialog, OkButton,
+                                  CancelButton, Buttons, icon_path, WWLabel, CloseButton)
 from electrum.gui.qt.qrcodewidget import QRCodeWidget
 from electrum.gui.qt.amountedit import AmountEdit
 from electrum.gui.qt.main_window import StatusBarButton
@@ -254,7 +256,7 @@ class Plugin(TrustedCoinPlugin):
 
         tos_e.tos_signal.connect(on_result)
         tos_e.error_signal.connect(on_error)
-        t = Thread(target=request_TOS)
+        t = threading.Thread(target=request_TOS)
         t.setDaemon(True)
         t.start()
         email_e.textChanged.connect(set_enabled)

electrum/plugins/virtualkeyboard/qt.py

@@ -1,8 +1,9 @@
-from PyQt5.QtGui import *
+import random
+
 from PyQt5.QtWidgets import (QVBoxLayout, QGridLayout, QPushButton)
+
 from electrum.plugin import BasePlugin, hook
 from electrum.i18n import _
-import random
 
 
 class Plugin(BasePlugin):