From 010b153ab26676ae345cbeca0cddb48d09bc2f3c Mon Sep 17 00:00:00 2001 From: Sander van Grieken Date: Fri, 17 Jan 2025 12:15:24 +0100 Subject: [PATCH] qml: fix regression caused by ee42e09387b64ba8c5f40128d082ee1c0ac21b77 in qml, we need the password in-memory as the auth wrapper (@auth_protect) does not pass the password to the wrapped fn. --- electrum/gui/qml/qedaemon.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/electrum/gui/qml/qedaemon.py b/electrum/gui/qml/qedaemon.py index 356427431..7f7c57b9d 100644 --- a/electrum/gui/qml/qedaemon.py +++ b/electrum/gui/qml/qedaemon.py @@ -251,8 +251,8 @@ class QEDaemon(AuthMixin, QObject): assert wallet is not None self._current_wallet = QEWallet.getInstanceFor(wallet) self.availableWallets.updateWallet(self._path) - if wallet.requires_unlock(): - wallet.unlock(password or None) + wallet.unlock(password or None) # not conditional on wallet.requires_unlock in qml, as + # the auth wrapper doesn't pass the entered password, but instead we rely on the password in memory self._loading = False self.loadingChanged.emit() self.walletLoaded.emit(self._name, self._path)